They do the job by trapping h2o In the curve and blocking the gas from returning to the home. If your smell comes from a sink, operate the drinking water for the couple of seconds to revive the trap. In case the smell comes from a ground drain such as a shower drain, pour a pitcher of drinking water down the drain to revive the appropriate function